Firmware Encoding Index UEFI DEV Mailing List Search This Site





Subject:
Re: [edk2] [PATCH v3 04/15] OvmfPkg: VirtioNetDxe: Component Name Protocol implementation
From:
Laszlo Ersek
Date:
5/29/2013 8:45 AM
To:
Jordan Justen
CC:
"edk2-devel@lists.sourceforge.net" <edk2-devel@lists.sourceforge.net>

On 05/28/13 20:37, Jordan Justen wrote:
> On Thu, May 16, 2013 at 6:01 AM, Laszlo Ersek <lersek@redhat.com> wrote:
>> Contributed-under: TianoCore Contribution Agreement 1.0
>>
>> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
>> ---
>>  OvmfPkg/VirtioNetDxe/ComponentName.c |  179 ++++++++++++++++++++++++++++++++++
>>  1 files changed, 179 insertions(+), 0 deletions(-)
>>  create mode 100644 OvmfPkg/VirtioNetDxe/ComponentName.c
>>
>> diff --git a/OvmfPkg/VirtioNetDxe/ComponentName.c b/OvmfPkg/VirtioNetDxe/ComponentName.c
>> new file mode 100644
>> index 0000000..458018a
>> --- /dev/null
>> +++ b/OvmfPkg/VirtioNetDxe/ComponentName.c
>> @@ -0,0 +1,179 @@
>> +/** @file
>> +
>> +  Component Name code for the virtio-net driver.
>> +
>> +  Copyright (C) 2013, Red Hat, Inc.
>> +
>> +  UEFI API documentation:
>> +  Copyright (c) 2006 - 2011, Intel Corporation. All rights reserved.<BR>
> 
> Can you remove the "UEFI API documentation:" and any similar
> qualifications to Intel's copyright notice? (This is present in
> several patches.)

If I removed the Intel copyright notices altogether, including any
qualifications, plus (obviously!) all the API doc comments that I copied
from other header files (which are covered by Intel's copyright), would
you then ask me to author original API documentation for those functions
that would now be left without API documentation? :)

I could (have) just place(d) UEFI spec references in front of the
affected interfaces (thereby shaving off about 30% of the series), but I
was worried that you'd call me out for breaking coding style. So I
copied the comments, which forced me to add the Intel copyright, but I
wanted to make it specific.

In any case if you still recommend to drop only the qualifications, I'll
do it in v4.

Thanks,
Laszlo


------------------------------------------------------------------------------
Introducing AppDynamics Lite, a free troubleshooting tool for Java/.NET
Get 100% visibility into your production application - at no cost.
Code-level diagnostics for performance bottlenecks with <2% overhead
Download for free and get started troubleshooting in minutes.
http://p.sf.net/sfu/appdyn_d2d_ap1
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel