[if gte mso 9]>

Re: [edk2] ShellPkg: Fix 'parse' command to use , " for SFO column delimiter

Subject: Re: [edk2] ShellPkg: Fix 'parse' command to use , " for SFO column delimiter

From: "Carsey, Jaben" <jaben.carsey@intel.com>

To: "Phillips, Chris J (Plano, TX)" <chrisp@hp.com>, "edk2-devel@lists.sourceforge.net" <edk2-devel@lists.sourceforge.net>

Date: 2014-11-21 07:08:13

Reviewed-by: Jaben Carsey jaben.carsey@intel.com

 

Revision 16412

 

From: Phillips, Chris J (Plano, TX) [mailto:chrisp@hp.com]
Sent: Thursday, November 20, 2014 7:55 AM
To: Carsey, Jaben; edk2-devel@lists.sourceforge.net
Subject: ShellPkg: Fix 'parse' command to use ," for SFO column delimiter
Importance: High

 

Please review the attached patch.

 

This updates the 'parse' command to use ," as the SFO column delimiter instead of just ,

 

Using just a comma resulted in device path strings being broken-up into multiple columns.  EX:

FS1:\> parse tmp.txt Mappings 3

PciRoot(0x0)/Pci(0x1

PciRoot(0x0)/Pci(0x1

 

Will now correctly be:

FS1:\> parse tmp.txt Mappings 3

PciRoot(0x0)/Pci(0x1,0x1)/Pci(0x0,0x0)/Scsi(0x0,0x0)/HD(1,MBR,0x111F3331,0x20,0x10AF20)

PciRoot(0x0)/Pci(0x1,0x1)/Pci(0x0,0x0)/Scsi(0x0,0x1)/HD(2,GPT,7ACDF3E5-0DC0-441A-831E-4D8609A6DC2E,0x96800,0x32000)

 

Based on following wording in shell spec (Appendix D), this delimiter will work.

  UEFI shell commands using standard formatted output display the same information they would normally display, except using rows and columns of comma-delimited data. The first column always contains a C-style identifier which describes the type of data on the row. This identifier is known as the table name. Table names which begin with the ‘_’ character are implementation-specific.

The second and subsequent columns are quoted C-style strings containing the actual UEFI shell command data. For each UEFI shell command, the format and meaning of each column depends on the column number and the table name.

 

Thanks,

Chris

 

 

 

ShellPkg: Fix 'parse' command to use ," for SFO column delimiter

 

Contributed-under: TianoCore Contribution Agreement 1.0

Signed-off-by: Chris Phillips <chrisp@hp.com>