[if gte mso 9]>

Re: [edk2] [BaseTools]There is a regression bug after enbaling s_* an d_* macros in FDF

Subject: Re: [edk2] [BaseTools]There is a regression bug after enbaling s_* an d_* macros in FDF

From: "Gao, Liming" <liming.gao@intel.com>

To: "edk2-devel@lists.sourceforge.net" <edk2-devel@lists.sourceforge.net>

Date: 2014-09-12 14:01:02

Dennis:

  The patch is good. Reviewed-by: Gao, Liming <liming.gao@intel.com>

 

  The commit log message may be updated.

 

BaseTools: Fix the regression issue after enbaling s_* an d_* macros in FDF.

 

Add the missing 'MacroDict' field in FfsInfStatement.

 

The issue is that BaseTools/Source/Python/GenFds/FfsInfStatement.py", line 448, in __ExtendMacro__

    String = GenFdsGlobalVariable.MacroExtend(String, self.MacroDict)

AttributeError: OptRomInfStatement instance has no attribute 'MacroDict'

 

Thanks

Liming

From: Liu, Yingke D [mailto:yingke.d.liu@intel.com]
Sent: Friday, September 12, 2014 1:55 PM
To: edk2-devel@lists.sourceforge.net
Subject: [edk2] [BaseTools]There is a regression bug after enbaling s_* an d_* macros in FDF

 

Hi,

 

Please review the patch to fix the regression bug:

 

BaseTools/Source/Python/GenFds/FfsInfStatement.py", line 448, in __ExtendMacro__

    String = GenFdsGlobalVariable.MacroExtend(String, self.MacroDict)

AttributeError: OptRomInfStatement instance has no attribute 'MacroDict'

 

Contributed-under: TianoCore Contribution Agreement 1.0

Signed-off-by: Yingke Liu <yingke.d.liu@intel.com>

 

Thanks,

Dennis