[if gte mso 9]>

Re: [edk2] [PATCH 1/1] ShellPkg: Use the new library for "bcfg" command

Subject: Re: [edk2] [PATCH 1/1] ShellPkg: Use the new library for "bcfg" command

From: "Shah, Tapan" <tapandshah@hp.com>

To: "Carsey, Jaben" <jaben.carsey@intel.com>, "Phillips, Chris J (Plano, TX)" <chrisp@hp.com>, "Bjorge, Erik C" <erik.c.bjorge@intel.com>

Date: 2014-09-06 00:01:52

Few lines were going beyond 80 characters in bcfg help output. So I have fixed them in attached .uni file.

 

From: Carsey, Jaben [mailto:jaben.carsey@intel.com]
Sent: Friday, September 05, 2014 10:48 AM
To: Shah, Tapan; Phillips, Chris J (Plano, TX); Bjorge, Erik C
Cc: edk2-devel@lists.sourceforge.net; Carsey, Jaben
Subject: RE: [PATCH 1/1] ShellPkg: Use the new library for "bcfg" command

 

I have corrected that encoding. Here is the UNI file itself.

 

I am now renaming the library and fixing some comments that chris pointed out.

 

-Jaben

 

From: Shah, Tapan [mailto:tapandshah@hp.com]
Sent: Friday, September 05, 2014 8:42 AM
To: Carsey, Jaben; Phillips, Chris J (Plano, TX); Bjorge, Erik C
Cc: edk2-devel@lists.sourceforge.net
Subject: RE: [PATCH 1/1] ShellPkg: Use the new library for "bcfg" command
Importance: High

 

UefiBcfgCommandLib.uni file can’t be patched due to missing diff in patch. It’s mime-type should be changed to “text/plain;encoding=UTF-16LE“

 

 

From: Carsey, Jaben [mailto:jaben.carsey@intel.com]
Sent: Friday, September 05, 2014 10:28 AM
To: Shah, Tapan; Phillips, Chris J (Plano, TX); Bjorge, Erik C
Cc: edk2-devel@lists.sourceforge.net; Carsey, Jaben
Subject: RE: [PATCH 1/1] ShellPkg: Use the new library for "bcfg" command

 

All the new files were added in the first patch.  This second patch removes the old code and moves the functionality to the added new library.

 

I can certainly rename the library.  I didn’t think about the name much.

 

I see the files removed from install around lines 3021 and 3111 in the patch 1/1 file.

 

-Jaben

 

From: Shah, Tapan [mailto:tapandshah@hp.com]
Sent: Friday, September 05, 2014 7:36 AM
To: Carsey, Jaben; Phillips, Chris J (Plano, TX); Bjorge, Erik C
Cc: edk2-devel@lists.sourceforge.net
Subject: RE: [PATCH 1/1] ShellPkg: Use the new library for "bcfg" command
Importance: High

 

Looks like patch is missing new files from ShellPkg/Library/UefiBcfgCommandLib/ directory. UefiShellInstall1CommandsLib.h and .uni files are removed from its .inf file in the patch, but don’t see those files deleted in the patch.

 

 

ShellPkg.dsc change:

 

  BcfgCommandLib|ShellPkg/Library/UefiBcfgCommandLib/UefiBcfgCommandLib.inf

 

Why not call it UefiShellBcfgCommandLib to remain consistent with other profile library naming convention for ShellPkg?

 

From: Carsey, Jaben [mailto:jaben.carsey@intel.com]
Sent: Thursday, September 04, 2014 5:33 PM
To: Shah, Tapan; Phillips, Chris J (Plano, TX); Bjorge, Erik C
Cc: edk2-devel@lists.sourceforge.net; Carsey, Jaben
Subject: [PATCH 1/1] ShellPkg: Use the new library for "bcfg" command

 

Erik, Tapan, or Chris,

 

Can you check this out?

 

The goal of the pair of patches is to refactor out the bcfg command from being in both Install1 and Debug1 command libraries.  Instead each of those libraries will link in this library and the code will exist in only one place.

 

ShellPkg: Use the new library for "bcfg" command

 

Contributed-under: TianoCore Contribution Agreement 1.0

Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>