Re: [edk2] [PATCH] MdePkg BaseLib NASM Thunk16: Initialize _16GdtrBase to 0

Subject: Re: [edk2] [PATCH] MdePkg BaseLib NASM Thunk16: Initialize _16GdtrBase to 0

From: Sergey Isakov <isakov-sl@bk.ru>

To: edk2-devel@lists.sourceforge.net

Date: 2014-09-04 01:42:56

Hi sirs,
In commit 16024 you forget to set 
ASM_PFX(InternalAsmThunk16)
in two places

Sergey

On 01.09.2014, at 16:28, Sergey Isakov wrote:


On 01.09.2014, at 14:58, Paolo Bonzini wrote:

Il 31/08/2014 20:23, Sergey Isakov ha scritto:
Clang assembler doesnt support 16 bit codes.

(please don't top-post)

Does Apple not ship gas anymore and replaces it with clang's integrated
assembler?
Yes, does not ship
-bash: gas: command not found

In either case, how the clang folks can say "use the clang integrated
assembler and file bugs" with a straight face when asked to upgrade
NASM?  This is not a bug that would have to be filed, it's a substantial
feature request...
This discussion began from the problem of Thunk16.S that contains db codes instead of real assembler mnemonic.
The instruction .code16 can't be compiled with clang integrated assembler.
Switching to nasm may resolve this problem as well as possiblity to use the same sources for all OSes.

Paolo

On 31 . 2014 ., at 20:16, Paolo Bonzini <pbonzini@redhat.com> wrote:

Il 30/08/2014 08:47, Jordan Justen ha scritto:
All,

Sergey reported that XCLANG was able to build and link with my latest
version. (Apparently he still has issues booting OVMF, but I don't
think it is specifically due to NASM Thunk16.)

Therefore, I'll commit the NASM series now with Liming's r-b.

I'll send out a separate email noting that NASM 2.07 or newer will now
be required for building BaseLib for IA32 & X64 (except Visual Studio
and ICC).

Out of curiosity, what's the reason for converting to NASM?  gas
supports both Intel syntax and 16-bit code.

Paolo


------------------------------------------------------------------------------
Slashdot TV.  
Video for Nerds.  Stuff that matters.
http://tv.slashdot.org/
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel


------------------------------------------------------------------------------
Slashdot TV.  
Video for Nerds.  Stuff that matters.
http://tv.slashdot.org/
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel



------------------------------------------------------------------------------
Slashdot TV.  
Video for Nerds.  Stuff that matters.
http://tv.slashdot.org/
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel


------------------------------------------------------------------------------
Slashdot TV.  
Video for Nerds.  Stuff that matters.
http://tv.slashdot.org/
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel