Re: [edk2] Regarding commit: ShellPkg: Update 'pci' command for updated class codes

Subject: Re: [edk2] Regarding commit: ShellPkg: Update 'pci' command for updated class codes

From: Andrew Fish <afish@apple.com>

To: edk2-devel@lists.sourceforge.net

Date: 2014-08-25 17:52:07


On Aug 25, 2014, at 8:41 AM, Carsey, Jaben <jaben.carsey@intel.com> wrote:

Do you know why it fails?
 
Is the < or > the incorrect ASCII character?
 

As Lasszio mentioned <96> is not a valid UTF-8 encoding. U+0096 is C2 96 in UTF-8. Not to mention U+0096 is a <control> character. So the file contains some non portable encoding. 

Thanks,

Andrew Fish

-Jaben
 
From: Neeraj Ladkani [mailto:neeraj.ladkani@gmail.com] 
Sent: Saturday, August 23, 2014 1:24 PM
To: edk2-devel@lists.sourceforge.net; Carsey, Jaben
Subject: Regarding commit: ShellPkg: Update 'pci' command for updated class codes
Importance: High
 
Hi Jaben, 
 
The recent commit f056e4c18047e9a0157a915175d07afbd8b8c581(Fri Aug 22 17:02:11) is broken on GCC 4.7, 
 
+  {
+    0x20,
+    L"Ethernet (802.11a <96> 5 GHz)",
+    PCIBlankEntry
+  },
+  {
+    0x21,
+    L"Ethernet (802.11b <96> 2.4 GHz)",
+    PCIBlankEntry
+  },
 
Reverting this push builds fine on GCC 4.7
 
 
 
Thanks 
Neeraj
 
------------------------------------------------------------------------------
Slashdot TV.  
Video for Nerds.  Stuff that matters.
http://tv.slashdot.org/_______________________________________________
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel