[if gte mso 9]>

Re: [edk2] ShellPkg: Add cross file system moving to MV command

Subject: Re: [edk2] ShellPkg: Add cross file system moving to MV command

From: "Carsey, Jaben" <jaben.carsey@intel.com>

To: "Phillips, Chris J (Plano, TX)" <chrisp@hp.com>, "Bjorge, Erik C" <erik.c.bjorge@intel.com>

Date: 2014-08-22 03:44:28

Yep.  I noticed that I forgot to include the .h change to make those functions accessible.

 

From: Phillips, Chris J (Plano, TX) [mailto:chrisp@hp.com]
Sent: Thursday, August 21, 2014 12:42 PM
To: Carsey, Jaben; Bjorge, Erik C
Cc: edk2-devel@lists.sourceforge.net
Subject: RE: ShellPkg: Add cross file system moving to MV command

 

Yes, looks like something is missing.  The shell build fails because it can’t find CopySingleFile() and CascadeDelete().  Looks like these are in Cp.c and Rm.c.

 

Chris

 

From: Carsey, Jaben [mailto:jaben.carsey@intel.com]
Sent: Thursday, August 21, 2014 2:39 PM
To: Phillips, Chris J (Plano, TX); Bjorge, Erik C
Cc: edk2-devel@lists.sourceforge.net; Carsey, Jaben
Subject: RE: ShellPkg: Add cross file system moving to MV command

 

I will merge the UNI in, not replace it.

 

I agree that I seemed to have lost something in this patch.  I will fix it and resend it.

 

From: Phillips, Chris J (Plano, TX) [mailto:chrisp@hp.com]
Sent: Thursday, August 21, 2014 12:27 PM
To: Bjorge, Erik C; Carsey, Jaben
Cc: edk2-devel@lists.sourceforge.net
Subject: RE: ShellPkg: Add cross file system moving to MV command
Importance: High

 

Jaben,

 

Looks like the .uni file needs some of the recent updates.

 

I will try to test it today, but I don’t see PostDelete ever getting set to TRUE.

I also don’t see CreateDirectory() getting called.  Is it really needed?

 

Thanks,

Chris

 

From: Bjorge, Erik C [mailto:erik.c.bjorge@intel.com]
Sent: Thursday, August 21, 2014 12:39 PM
To: Carsey, Jaben; Phillips, Chris J (Plano, TX)
Cc: edk2-devel@lists.sourceforge.net
Subject: RE: ShellPkg: Add cross file system moving to MV command

 

Reviewed-by: Erik Bjorge <erik.c.bjorge@intel.com>

 

From: Carsey, Jaben
Sent: Thursday, August 21, 2014 10:13 AM
To: Bjorge, Erik C; Phillips, Chris J (BCS CFE) (chrisp@hp.com)
Cc: edk2-devel@lists.sourceforge.net; Carsey, Jaben
Subject: ShellPkg: Add cross file system moving to MV command

 

Erik or Chris,

 

Can you review this?

 

The commit will also include removing this no longer used line form the UNI file (file attached for the very curious):

#string STR_MV_INV_FS             #language en-US "%EError. %NCannot move between file systems.\r\n"

 

ShellPkg: Add cross file system moving to MV command

 

 

Contributed-under: TianoCore Contribution Agreement 1.0

Signed-off-by: Jaben Carsey <jaben.carsey@intel.com>