Re: [edk2] [PATCH 0/2] StdLib: fix two instances of missing braces

Subject: Re: [edk2] [PATCH 0/2] StdLib: fix two instances of missing braces

From: Laszlo Ersek <lersek@redhat.com>

To: "Carsey, Jaben" <jaben.carsey@intel.com>

Date: 2014-08-06 00:49:57

On 08/02/14 02:19, Laszlo Ersek wrote:
> Laszlo Ersek (2):
>   StdLib/LibC/gdtoa: fix "missing braces around initializer"
>   StdLib/LibC/Stdio: fix "missing braces around initializer"
> 
>  StdLib/LibC/Stdio/vswscanf.c | 2 +-
>  StdLib/LibC/gdtoa/strtof.c   | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

Ping -- these patches are trivial.

Jaben, can you please review & commit them?

Alternatively, I guess the build options for StdLib could privately
re-introduce -Wno-missing-braces:


diff --git a/StdLib/LibC/Stdio/Stdio.inf b/StdLib/LibC/Stdio/Stdio.inf
index a61a558..301716f 100644
--- a/StdLib/LibC/Stdio/Stdio.inf
+++ b/StdLib/LibC/Stdio/Stdio.inf
@@ -144,4 +144,4 @@
 # Nasty things could happen if you do.
 #
 [BuildOptions]
-  GCC:*_*_*_CC_FLAGS    = -fno-builtin -Wno-pointer-to-int-cast -Wno-int-to-pointer-cast -Wno-format
+  GCC:*_*_*_CC_FLAGS    = -fno-builtin -Wno-pointer-to-int-cast -Wno-int-to-pointer-cast -Wno-format -Wno-missing-braces
diff --git a/StdLib/LibC/gdtoa/gdtoa.inf b/StdLib/LibC/gdtoa/gdtoa.inf
index fbe3ac1..722164e 100644
--- a/StdLib/LibC/gdtoa/gdtoa.inf
+++ b/StdLib/LibC/gdtoa/gdtoa.inf
@@ -75,3 +75,6 @@
   LibLocale
   LibStdLib
   LibString
+
+[BuildOptions]
+  GCC:*_*_*_CC_FLAGS    = -Wno-missing-braces


I'm fine either way, but right now, with current BaseTools, StdLib
doesn't build with gcc.

Thanks,
Laszlo


------------------------------------------------------------------------------
Infragistics Professional
Build stunning WinForms apps today!
Reboot your WinForms applications with our WinForms controls. 
Build a bridge from your legacy apps to the future.
http://pubads.g.doubleclick.net/gampad/clk?id=153845071&iu=/4140/ostg.clktrk
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel