[if gte mso 9]>
Subject: Re: [edk2] MdeModulePkg: Fix parameter verification for SetAttribute
From: "Li, Elvin" <email@example.com>
To: "firstname.lastname@example.org" <email@example.com>, "Bjorge, Erik C" <firstname.lastname@example.org>, "Kinney, Michael D" <email@example.com>, "Carsey, Jaben" <firstname.lastname@example.org>
Date: 2014-07-25 09:44:45
Your fix is right. I also checked terminal console driver, its SetAttribute has no such problem.
Reviewed-by: Elvin Li <email@example.com>
Erik & Mike,
Can you please check this? I found this during debug and I realize that this is not verifying the correct number of bits. I need to get an error when the 8th bit being set.
Reference from UEFI 2.4B SetAttribute() API:
Attribute The attribute to set. Bits 0..3 are the foreground color, and bits 4..6 are the background color. All other bits are reserved. See “Related Definitions” below.
MdeModulePkg: Fix parameter verification for SetAttribute
Check for 8th bit being reserved as per UEFI spec.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jaben Carsey <Jaben.firstname.lastname@example.org>