[if gte mso 9]>

Re: [edk2] MdeModulePkg: Fix parameter verification for SetAttribute

Subject: Re: [edk2] MdeModulePkg: Fix parameter verification for SetAttribute

From: "Li, Elvin" <elvin.li@intel.com>

To: "edk2-devel@lists.sourceforge.net" <edk2-devel@lists.sourceforge.net>, "Bjorge, Erik C" <erik.c.bjorge@intel.com>, "Kinney, Michael D" <michael.d.kinney@intel.com>, "Carsey, Jaben" <jaben.carsey@intel.com>

Date: 2014-07-25 09:44:45

Jaben,

                Your fix is right. I also checked terminal console driver, its SetAttribute has no such problem.

 

                Reviewed-by: Elvin Li <elvin.li@intel.com>

 

 

Thanks

Elvin

From: Carsey, Jaben [mailto:jaben.carsey@intel.com]
Sent: Friday, July 25, 2014 6:59 AM
To: Bjorge, Erik C; Kinney, Michael D
Cc: edk2-devel@lists.sourceforge.net
Subject: [edk2] MdeModulePkg: Fix parameter verification for SetAttribute

 

Erik & Mike,

 

Can you please check this?  I found this during debug and I realize that this is not verifying the correct number of bits.  I need to get an error when the 8th bit being set.

 

Reference from UEFI 2.4B SetAttribute() API:

Attribute                                               The attribute to set.  Bits 0..3 are the foreground color, and bits 4..6 are the background color.  All other bits are reserved.  See “Related Definitions” below. 

 

MdeModulePkg: Fix parameter verification for SetAttribute

 

Check for 8th bit being reserved as per UEFI spec.

 

Contributed-under: TianoCore Contribution Agreement 1.0

Signed-off-by: Jaben Carsey <Jaben.carsey@intel.com>