[if gte mso 9]>

Re: [edk2] MdeModulePkg: Fix parameter verification for SetAttribute

Subject: Re: [edk2] MdeModulePkg: Fix parameter verification for SetAttribute

From: "Kinney, Michael D" <michael.d.kinney@intel.com>

To: "Bjorge, Erik C" <erik.c.bjorge@intel.com>, "Carsey, Jaben" <jaben.carsey@intel.com>, "Kinney, Michael D" <michael.d.kinney@intel.com>

Date: 2014-07-25 07:54:06

Reviewed-by: Michael Kinney <michael.d.kinney@intel.com>

 

From: Bjorge, Erik C
Sent: Thursday, July 24, 2014 4:15 PM
To: Carsey, Jaben; Kinney, Michael D
Cc: edk2-devel@lists.sourceforge.net
Subject: RE: MdeModulePkg: Fix parameter verification for SetAttribute

 

Reviewed-by: Erik Bjorge <erik.c.bjorge@intel.com>

 

From: Carsey, Jaben
Sent: Thursday, July 24, 2014 3:59 PM
To: Bjorge, Erik C; Kinney, Michael D
Cc: edk2-devel@lists.sourceforge.net; Carsey, Jaben
Subject: MdeModulePkg: Fix parameter verification for SetAttribute

 

Erik & Mike,

 

Can you please check this?  I found this during debug and I realize that this is not verifying the correct number of bits.  I need to get an error when the 8th bit being set.

 

Reference from UEFI 2.4B SetAttribute() API:

Attribute                                               The attribute to set.  Bits 0..3 are the foreground color, and bits 4..6 are the background color.  All other bits are reserved.  See “Related Definitions” below. 

 

MdeModulePkg: Fix parameter verification for SetAttribute

 

Check for 8th bit being reserved as per UEFI spec.

 

Contributed-under: TianoCore Contribution Agreement 1.0

Signed-off-by: Jaben Carsey <Jaben.carsey@intel.com>