Re: [edk2] [PATCH v2 2/2] OvmfPkg/SMBIOS: Add QEMU support to OVMF SMBIOS driver

Subject: Re: [edk2] [PATCH v2 2/2] OvmfPkg/SMBIOS: Add QEMU support to OVMF SMBIOS driver

From: "Gabriel L. Somlo" <gsomlo@gmail.com>

To: Jordan Justen <jljusten@gmail.com>

Date: 2014-05-20 19:49:03

Hi Jordan,

On Tue, May 20, 2014 at 08:30:14AM -0700, Jordan Justen wrote:
> I still had the question from v1 of whether we should document the
> known fw-cfg filenames with #defines in
> OvmfPkg/Include/Library/QemuFwCfgLib.h.

So I don't (yet) feel qualified to answer that, based on being still
somewhat new to the coding style of edk2 :) I can help do that if it
ends up being declared a "Good Thing (TM)" by someone more experienced
and familiar with the project... :) I sort-of tried to allude to this
in the v2 cover letter (or was it somewhere earlier in the v1 thread?).

Anyhow, since it'd be somewhat orthogonal to SMBIOS, I think we should
be able to address all of that (including for the two smbios fwcfg files)
in that potential future patch, right ?
 
> But, series Reviewed-by: Jordan Justen 

Thanks !

Regards,
--Gabriel

------------------------------------------------------------------------------
"Accelerate Dev Cycles with Automated Cross-Browser Testing - For FREE
Instantly run your Selenium tests across 300+ browser/OS combos.
Get unparalleled scalability from the best Selenium testing platform available
Simple to use. Nothing to install. Get started now for free."
http://p.sf.net/sfu/SauceLabs
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel