Re: [edk2] missing return statements in r15339?

Subject: Re: [edk2] missing return statements in r15339?

From: Laszlo Ersek <>

To: "Dong, Guo" <>

Date: 2014-03-20 20:30:07

On 03/20/14 02:09, Dong, Guo wrote:
> Hi Laszlo,
> Thanks for the comments.
> As you know, Variable Write Arch Protocol is an Arch protocol, if the
> variable driver didn't install it and directly return, it might bring
> system hang since some drivers that depend on this Arch protocol
> could not be dispatched. So here we prefer installing this Arch
> protocol to continue boot, even some Variable service might fail.

Ah OK. If the only consequence of proceeding past those checks is that
the variable services will consistently fail and return error codes,
then that's indeed better than hanging mid-dispatch.

I assumed that the failure of VariableWriteServiceInitialize() would
cause corruption / crash farther down the road, when the variable
services tried to use that missing piece of infrastructure "blindly". If
failure of VariableWriteServiceInitialize() only causes controlled
failures in the dependent services code, then that's a relief. Thank you
for explaining.


Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and their
applications. Written by three acclaimed leaders in the field,
this first edition is now available. Download your free book today!
edk2-devel mailing list