Re: [edk2] [PATCH 4/5] OvmfPkg: VirtioBlkInit(): expose virtio-blk topology in BlockIo

Subject: Re: [edk2] [PATCH 4/5] OvmfPkg: VirtioBlkInit(): expose virtio-blk topology in BlockIo

From: Laszlo Ersek <lersek@redhat.com>

To: edk2-devel@lists.sourceforge.net

Date: 2013-12-18 04:19:00

On 12/17/13 19:51, Jordan Justen wrote:
> On Sun, Dec 15, 2013 at 10:36 AM, Laszlo Ersek  wrote:
>> UEFI spec                                virtio spec
>> =======================================  =================================
>> LowestAlignedLba EFI_LBA (UINT64)        alignment_offset u8
>> +--------------------------------------  +--------------------------------
>> | first LBA that is aligned to a         | offset of first aligned
>> | physical block boundary (SCSI          | logical block
>> | definition)
>>
>> LogicalBlocksPerPhysicalBlock UINT32     physical_block_exp u8
>> +--------------------------------------  +--------------------------------
>> | number of logical blocks per           | # of logical blocks per
>> | physical block [...] does not contain  | physical block (log2)
>> | an exponential value
>>
>> OptimalTransferLengthGranularity UINT32  opt_io_size le32
>> +--------------------------------------  +--------------------------------
>> | optimal transfer length granularity    | optimal (suggested maximum) I/O
>> | as a number of logical blocks [...] A  | size in blocks
>> | value of 0 means there is no reported
>> | optimal transfer length granularity
>>
>> Contributed-under: TianoCore Contribution Agreement 1.0
>> Signed-off-by: Laszlo Ersek 
>> ---
>>  OvmfPkg/VirtioBlkDxe/VirtioBlk.c | 38 +++++++++++++++++++++++++++++++++++---
>>  1 file changed, 35 insertions(+), 3 deletions(-)
>>
>> diff --git a/OvmfPkg/VirtioBlkDxe/VirtioBlk.c b/OvmfPkg/VirtioBlkDxe/VirtioBlk.c
>> index 5815cdf..181e5d1 100644
>> --- a/OvmfPkg/VirtioBlkDxe/VirtioBlk.c
>> +++ b/OvmfPkg/VirtioBlkDxe/VirtioBlk.c
>> @@ -595,6 +595,9 @@ VirtioBlkInit (
>>    UINT32     Features;
>>    UINT64     NumSectors;
>>    UINT32     BlockSize;
>> +  UINT8      PhysicalBlockExp;
>> +  UINT8      AlignmentOffset;
>> +  UINT32     OptIoSize;
> 
> VS considers these to be potentially used before initialization. Do
> you want me to fix this?

Please do :)

> 
> For series:
> Reviewed-by: Jordan Justen 

Thanks!

Laszlo


------------------------------------------------------------------------------
Rapidly troubleshoot problems before they affect your business. Most IT 
organizations don't have a clear picture of how application performance 
affects their revenue. With AppDynamics, you get 100% visibility into your 
Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
http://pubads.g.doubleclick.net/gampad/clk?id=84349831&iu=/4140/ostg.clktrk
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel