Re: [edk2] [PATCH] ShellPkg pci command: Fix some newline character typos

Subject: Re: [edk2] [PATCH] ShellPkg pci command: Fix some newline character typos

From: "Carsey, Jaben" <jaben.carsey@intel.com>

To: "Justen, Jordan L" <jordan.l.justen@intel.com>, "edk2-devel@lists.sourceforge.net" <edk2-devel@lists.sourceforge.net>

Date: 2013-11-20 06:29:53

For the incorrect slashes:
Reviewed-by: Jaben Carsey 

For the removing of the "\r" - I don't see any value to make that one place different from all the rest.

-Jaben

-----Original Message-----
From: Justen, Jordan L 
Sent: Thursday, November 14, 2013 8:35 PM
To: edk2-devel@lists.sourceforge.net
Cc: Justen, Jordan L; Carsey, Jaben
Subject: [PATCH] ShellPkg pci command: Fix some newline character typos

In the /r/n case, it caused a visible defect. The other change is just for consistency.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Jordan Justen 
Cc: Jaben Carsey 
---
 ShellPkg/Library/UefiShellDebug1CommandsLib/Pci.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/Pci.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/Pci.c
index 4ca1fd1..175f54e 100644
--- a/ShellPkg/Library/UefiShellDebug1CommandsLib/Pci.c
+++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/Pci.c
@@ -2405,7 +2405,7 @@ ShellCommandRunPci (
     SizeOfHeader = sizeof (ConfigSpace.Common) + sizeof (ConfigSpace.NonCommon);
 
     DumpHex (2, 0, SizeOfHeader, &ConfigSpace);
-    ShellPrintEx(-1,-1, L"\r\n");
+    ShellPrintEx(-1,-1, L"\n");
 
     //
     // Dump device dependent Part of configuration space @@ -2657,7 +2657,7 @@ PciExplainData (
   //
   // Print register Revision ID
   //
-  ShellPrintEx(-1, -1, L"/r/n");
+  ShellPrintEx(-1, -1, L"\n");
   ShellPrintHiiEx(-1, -1, NULL, STRING_TOKEN (STR_PCI_LINE_RID), gShellDebug1HiiHandle,
     INDEX_OF (&(Common->RevisionId)),
     Common->RevisionId
--
1.8.4.2


------------------------------------------------------------------------------
Shape the Mobile Experience: Free Subscription
Software experts and developers: Be at the forefront of tech innovation.
Intel(R) Software Adrenaline delivers strategic insight and game-changing 
conversations that shape the rapidly evolving mobile landscape. Sign up now. 
http://pubads.g.doubleclick.net/gampad/clk?id=63431311&iu=/4140/ostg.clktrk
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel