[if gte mso 9]>

Re: [edk2] Recall: GNUMakefile comment need to be improved

Subject: Re: [edk2] Recall: GNUMakefile comment need to be improved

From: "Gao, Liming" <liming.gao@intel.com>

To: "Parmeshwr_Prasad@Dell.com" <Parmeshwr_Prasad@Dell.com>, "Lu, Ken" <ken.lu@intel.com>, "Li, Godkey" <godkey.li@intel.com>, "Ye, Ted" <ted.ye@intel.com>, "Lin, Sen" <sen.lin@intel.com>, "Wang, EikanX" <eikanx.wang@intel.com>, "He, Kenny" <kenny.he@intel.com>, "Xu, Yi" <yi.xu@intel.com>

Date: 2013-07-17 17:27:20

Yes. Please create the patch and send it for review. If the patch is OK,I could help commit it.

 

From: Parmeshwr_Prasad@Dell.com [mailto:Parmeshwr_Prasad@Dell.com]
Sent: Wednesday, July 17, 2013 5:14 PM
To: Gao, Liming; Lu, Ken; Li, Godkey; Ye, Ted; Lin, Sen; Wang, EikanX; He, Kenny; Xu, Yi
Cc: Liu, Yingke D; edk2-devel@lists.sourceforge.net; ARLAR-3AdolfoBioyCasaresVideoConfRmAuthor@Dell.com
Subject: RE: [edk2] Recall: GNUMakefile comment need to be improved

 

Hi Liming,

 

I have found similar issue in may files, please go through the attachments.

Please let me know if you want me to create patch for all mentioned files.

File name

Error/Mistake

BeagleBoarsPkg/Tools/GNUmakefile

No

DuetPkg/BootSector/GNUmakefile

No

BaseTool/Source/Python/GNUmakefile

No

BaseTool/Source/C/TianoCompress/GNUmakefile

Yes

BaseTool/Source/C/GenCrc32/GNUmakefile

Yes

BaseTool/Source/C/EfiRom/GNUmakefile

Yes

BaseTool/Source/C/GnuGenBootSector/GNUmakefile

Yes

BaseTool/Source/C/Common/GNUmakefile

Yes

BaseTool/Source/C/GenVtf/GNUmakefile

Yes

BaseTool/Source/C/EfiLdeImage/GNUmakefile

Yes

BaseTool/Source/C/VolInfo/GNUmakefile

Yes

BaseTool/Source/C/VfrCompile/GNUmakefile

Yes

BaseTool/Source/C/GenSec/GNUmakefile

Yes

BaseTool/Source/C/GenFfs/GNUmakefile

Yes

BaseTool/Source/C/Split/GNUmakefile

Yes

BaseTool/Source/C/GNUmakefile

No

BaseTool/Source/C/LzmaCompress/GNUmakefile

Yes

BaseTool/Source/C/BootSecImage/GNUmakefile

Yes

BaseTool/Source/C/GenPage/GNUmakefile

Yes

BaseTool/Source/C/GenFw/GNUmakefile

Yes

BaseTool/Source/C/GenFv/GNUmakefile

Yes

BaseTool/Test/GNUmakefile

Yes

BaseTool/GNUmakefile

No

 

 

Regards

Parmeshwr

 

-----Original Message-----
From: Prasad, Parmeshwr
Sent: Monday, July 15, 2013 11:19 AM
To: liming.gao@intel.com; ken.lu@intel.com; godkey.li@intel.com; ted.ye@intel.com; sen.lin@intel.com; eikanx.wang@intel.com; kenny.he@intel.com; yi.xu@intel.com
Cc: yingke.d.liu@intel.com; edk2-devel@lists.sourceforge.net; .AR LAR-3 Adolfo Bioy Casares Video Conf Rm Author
Subject: Re: [edk2] Recall: GNUMakefile comment need to be improved

 

Thanks Liming for quick reply.

 

 

-----Original Message-----

From: Gao, Liming [mailto:liming.gao@intel.com]

Sent: Monday, July 15, 2013 10:33 AM

To: Prasad, Parmeshwr; Lu, Ken; Li, Godkey; Ye, Ted; Lin, Sen; Wang, EikanX; He, Kenny; Xu, Yi

Cc: edk2-devel@lists.sourceforge.net; .AR LAR-3 Adolfo Bioy Casares Video Conf Rm Author; Gao, Liming; Liu, Yingke D

Subject: RE: [edk2] Recall: GNUMakefile comment need to be improved

 

Hi:

   I have committed your change into BaseTools project at 2587.

 

-----Original Message-----

From: Parmeshwr_Prasad@Dell.com [mailto:Parmeshwr_Prasad@Dell.com]

Sent: Monday, July 15, 2013 12:55 PM

To: Lu, Ken; Li, Godkey; Ye, Ted; Lin, Sen; Wang, EikanX; He, Kenny; Xu, Yi

Cc: edk2-devel@lists.sourceforge.net; ARLAR-3AdolfoBioyCasaresVideoConfRmAuthor@Dell.com

Subject: Re: [edk2] Recall: GNUMakefile comment need to be improved

 

Hi All,

 

Can I know what stage is the changes done by me ?

 

-----Original Message-----

From: Lu, Ken [mailto:ken.lu@intel.com]

Sent: Thursday, July 11, 2013 1:56 PM

To: Li, Godkey; Ye, Ted; Lin, Sen; Wang, EikanX; He, Kenny; Xu, Yi

Cc: 'edk2-devel@lists.sourceforge.net'

Subject: [edk2] Recall: GNUMakefile comment need to be improved

 

Lu, Ken would like to recall the message, "[edk2] GNUMakefile comment need to be improved".

------------------------------------------------------------------------------

See everything from the browser to the database with AppDynamics Get end-to-end visibility with application monitoring from AppDynamics Isolate bottlenecks and diagnose root cause in seconds.

Start your free trial of AppDynamics Pro today!

http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk

_______________________________________________

edk2-devel mailing list

edk2-devel@lists.sourceforge.net

https://lists.sourceforge.net/lists/listinfo/edk2-devel

 

------------------------------------------------------------------------------

See everything from the browser to the database with AppDynamics Get end-to-end visibility with application monitoring from AppDynamics Isolate bottlenecks and diagnose root cause in seconds.

Start your free trial of AppDynamics Pro today!

http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk

_______________________________________________

edk2-devel mailing list

edk2-devel@lists.sourceforge.net

https://lists.sourceforge.net/lists/listinfo/edk2-devel

 

------------------------------------------------------------------------------

See everything from the browser to the database with AppDynamics Get end-to-end visibility with application monitoring from AppDynamics Isolate bottlenecks and diagnose root cause in seconds.

Start your free trial of AppDynamics Pro today!

http://pubads.g.doubleclick.net/gampad/clk?id=48808831&iu=/4140/ostg.clktrk

_______________________________________________

edk2-devel mailing list

edk2-devel@lists.sourceforge.net

https://lists.sourceforge.net/lists/listinfo/edk2-devel