Re: [edk2] [PATCH] MdeModulePkg: fix PXE_DISCOVERY_CONTROL parsing in UefiPxeBcDxe

Subject: Re: [edk2] [PATCH] MdeModulePkg: fix PXE_DISCOVERY_CONTROL parsing in UefiPxeBcDxe

From: Laszlo Ersek <>

To: "Fu, Siyuan" <>

Date: 2013-05-09 19:42:40

On 05/09/13 10:58, Laszlo Ersek wrote:
> On 05/09/13 07:31, Fu, Siyuan wrote:
>> Hi, Ersek
>> Thanks for your patch, we have checked-in it into EDK II (r14332).
> Awesome, thanks!
> L.

Actually, is there any reason that

(a) you dropped the original subject of my submission,
(b) you dropped the bug analysis from the commit message,
(c) you dropped the

    Contributed-under: TianoCore Contribution Agreement 1.0

    line from the commit message (actually, the *entire* commit

(d) you dropped the Red Hat copyright notices from the files my patch
    updated, and bumped the Intel copyright notices instead?

As far as I can see the code has been taken verbatim, modulo folding my
carefully < 80 chars/line comments into overlong lines.


Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and 
their applications. This 200-page book is written by three acclaimed 
leaders in the field. The early access version is available now. 
Download your free book today!
edk2-devel mailing list