Re: [edk2] [PATCH] ShellPkg: Check the error of gRT->GetTime()

Subject: Re: [edk2] [PATCH] ShellPkg: Check the error of gRT->GetTime()

From: Jordan Justen <jordan.l.justen@intel.com>

To: Andrew Fish <afish@apple.com>, Olivier Martin <olivier.martin@arm.com>

Date: 2013-05-09 18:01:23

On Thu, 2013-05-09 at 09:48 -0700, Andrew Fish wrote:
> I don't see why we assume that the time is always correct?
> What happens if you lose the battery and your driver knows the time
> is not valid per the UEFI spec it would return EFI_DEVICE_ERROR?
> It seems reasonable for the code calling GetTime() to deal with a
> EFI_DEVICE_ERROR return. 
> 
> EFI_DEVICE_ERROR
> The time could not be retrieved due to a hardware error.

Good points. Although, it doesn't seem to have been much of an
issue in the past...

Olivier,

Is FatPkg and ShellPkg the only issues you've found? If not, at this
point do you have any idea how extensive this issue is? (How much
code needs to be updated.)

-Jordan



------------------------------------------------------------------------------
Learn Graph Databases - Download FREE O'Reilly Book
"Graph Databases" is the definitive new guide to graph databases and 
their applications. This 200-page book is written by three acclaimed 
leaders in the field. The early access version is available now. 
Download your free book today! http://p.sf.net/sfu/neotech_d2d_may
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel