Re: [edk2] [PATCH v2] OvmfPkg: VirtioLib: populate the Available Ring correctly

Subject: Re: [edk2] [PATCH v2] OvmfPkg: VirtioLib: populate the Available Ring correctly

From: Jordan Justen <jljusten@gmail.com>

To: Laszlo Ersek <lersek@redhat.com>

Date: 2013-04-28 01:28:05

On Tue, Apr 23, 2013 at 3:18 AM, Laszlo Ersek  wrote:
> @@ -199,13 +198,9 @@ VirtioPrepare (
>
>    In *Indices:
>
> -  @param [in] HeadIdx           The index identifying the head buffer (first
> -                                buffer appended) belonging to this same
> -                                request.
> -
> -  @param [in out] NextAvailIdx  On input, the index identifying the next
> -                                descriptor available to carry the buffer. On
> -                                output, incremented by one, modulo 2^16.
> +  @param [in out] NextDescIdx  On input, the index identifying the next
> +                               descriptor to carry the buffer. On output,
> +                               incremented by one, modulo 2^16.

Can you use @param just with the actual parameters?

Do you think an addition to OvmfPkg/README for Virtio usage would be useful?

-Jordan

------------------------------------------------------------------------------
Try New Relic Now & We'll Send You this Cool Shirt
New Relic is the only SaaS-based application performance monitoring service 
that delivers powerful full stack analytics. Optimize and monitor your
browser, app, & servers with just a few lines of code. Try New Relic
and get this awesome Nerd Life shirt! http://p.sf.net/sfu/newrelic_d2d_apr
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel