Re: [edk2] [Qemu-devel] [RFC PATCH] Distinguish between reset types

Subject: Re: [edk2] [Qemu-devel] [RFC PATCH] Distinguish between reset types

From: Paolo Bonzini <pbonzini@redhat.com>

To: edk2-devel@lists.sourceforge.net

Date: 2013-02-21 17:36:33

Il 21/02/2013 02:10, Laszlo Ersek ha scritto:
> OTOH if the keyboard reset gets soft in qemu, then OVMF's hard reset
> (the above code) will break. Maybe I could cycle between 0xCF9 and 0x64
> in ResetCold(), starting with 0xCF9.

Yes, that's the right thing to do.

Also, in QEMU you're doing:

    if (val & 4) {
        qemu_system_reset_request();
        return;
    }
    d->rcr = val & 2; /* keep System Reset type only */

It looks like d->rcr should be set first to match what hardware does
(writing 0x6 causes a cold reset, and that's what you usually find in
the ACPI tables).

Paolo

------------------------------------------------------------------------------
Everyone hates slow websites. So do we.
Make your web apps faster with AppDynamics
Download AppDynamics Lite for free today:
http://p.sf.net/sfu/appdyn_d2d_feb
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel