Re: [edk2] [PATCH 00/13] virtio-scsi driver

Subject: Re: [edk2] [PATCH 00/13] virtio-scsi driver

From: Jordan Justen <jljusten@gmail.com>

To: edk2-devel@lists.sourceforge.net, Laszlo Ersek <lersek@redhat.com>

Date: 2012-10-11 16:26:27

1-11 & 13: Reviewed-by: Jordan Justen 

Still looking over 12...

-Jordan

On Tue, Oct 9, 2012 at 12:42 PM, Laszlo Ersek  wrote:
> Patches 01-11 distill VirtioLib. Patches 12-13 add the driver and the
> matching QemuBootOrder pattern.
>
> Tested the following scenarios (RHEL-6.3 host):
>
> - virtio-blk regression test:
>   - disk: Fedora 18 Alpha XFCE (grub2) boots fully
>   - disk: Windows 8 Consumer Preview (Build 8250) boots fully
>
> - virtio-scsi:
>   - disk: RHEL-6.3 (grub1) boots fully
>   - disk: Windows 8 Consumer Preview (Build 8250) boots fully
>   - CD-ROM: Windows 8 Consumer Preview (Build 8250) installer ISO boots
>     (shut down manually at first GUI window)
>   - host LUN passthrough: USB pen drive with one FAT32 partition
>     traversed in OVMF file browser
>
> Laszlo Ersek (12):
>   OvmfPkg: add inclusion guards to VirtioBlkDxe/VirtioBlk.h
>   OvmfPkg: move VirtioBlkDxe/Virtio.h to
>     Include/IndustryStandard/Virtio.h
>   OvmfPkg: add inclusion guards in Include/IndustryStandard/Virtio.h
>   OvmfPkg: IndustryStandard/Virtio.h: use OFFSET_OF in OFFSET_OF_VHDR
>   OvmfPkg: regroup virtio config fields into generic & specific structs
>   OvmfPkg: rename OFFSET_OF_VHDR() / SIZE_OF_VHDR() to *_OF_VBLK()
>   OvmfPkg: Include/IndustryStandard: extract VirtioBlk.h from Virtio.h
>   OvmfPkg: extract VirtioLib from VirtioBlkDxe
>   OvmfPkg: rename AppendDesc to VirtioAppendDesc
>   OvmfPkg: librarize reusable bits from VirtioBlkDxe's
>     SynchronousRequest()
>   OvmfPkg: introduce virtio-scsi driver
>   OvmfPkg: QemuBootOrder: recognize virtio-scsi devices
>
> Mike Lee (1):
>   OvmfPkg: MSVC build fixes for VirtioLib and VirtioBlkDxe
>
>  OvmfPkg/Include/IndustryStandard/Virtio.h      |  131 +++
>  OvmfPkg/Include/IndustryStandard/VirtioBlk.h   |   80 ++
>  OvmfPkg/Include/IndustryStandard/VirtioScsi.h  |  100 ++
>  OvmfPkg/Include/Library/VirtioLib.h            |  251 +++++
>  OvmfPkg/Library/PlatformBdsLib/QemuBootOrder.c |   45 +
>  OvmfPkg/Library/VirtioLib/VirtioLib.c          |  452 +++++++++
>  OvmfPkg/Library/VirtioLib/VirtioLib.inf        |   36 +
>  OvmfPkg/OvmfPkg.dec                            |   11 +
>  OvmfPkg/OvmfPkgIa32.dsc                        |    2 +
>  OvmfPkg/OvmfPkgIa32.fdf                        |    1 +
>  OvmfPkg/OvmfPkgIa32X64.dsc                     |    2 +
>  OvmfPkg/OvmfPkgIa32X64.fdf                     |    1 +
>  OvmfPkg/OvmfPkgX64.dsc                         |    2 +
>  OvmfPkg/OvmfPkgX64.fdf                         |    1 +
>  OvmfPkg/VirtioBlkDxe/Virtio.h                  |  176 ----
>  OvmfPkg/VirtioBlkDxe/VirtioBlk.c               |  423 +--------
>  OvmfPkg/VirtioBlkDxe/VirtioBlk.h               |    7 +-
>  OvmfPkg/VirtioBlkDxe/VirtioBlk.inf             |    2 +
>  OvmfPkg/VirtioScsiDxe/VirtioScsi.c             | 1260 ++++++++++++++++++++++++
>  OvmfPkg/VirtioScsiDxe/VirtioScsi.h             |  209 ++++
>  OvmfPkg/VirtioScsiDxe/VirtioScsi.inf           |   47 +
>  21 files changed, 2671 insertions(+), 568 deletions(-)
>  create mode 100644 OvmfPkg/Include/IndustryStandard/Virtio.h
>  create mode 100644 OvmfPkg/Include/IndustryStandard/VirtioBlk.h
>  create mode 100644 OvmfPkg/Include/IndustryStandard/VirtioScsi.h
>  create mode 100644 OvmfPkg/Include/Library/VirtioLib.h
>  delete mode 100644 OvmfPkg/VirtioBlkDxe/Virtio.h
>  create mode 100644 OvmfPkg/VirtioScsiDxe/VirtioScsi.h
>  create mode 100644 OvmfPkg/Library/VirtioLib/VirtioLib.c
>  create mode 100644 OvmfPkg/VirtioScsiDxe/VirtioScsi.c
>  create mode 100644 OvmfPkg/Library/VirtioLib/VirtioLib.inf
>  create mode 100644 OvmfPkg/VirtioScsiDxe/VirtioScsi.inf
>
>
> ------------------------------------------------------------------------------
> Don't let slow site performance ruin your business. Deploy New Relic APM
> Deploy New Relic app performance management and know exactly
> what is happening inside your Ruby, Python, PHP, Java, and .NET app
> Try New Relic at no cost today and get our sweet Data Nerd shirt too!
> http://p.sf.net/sfu/newrelic-dev2dev
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/edk2-devel

------------------------------------------------------------------------------
Don't let slow site performance ruin your business. Deploy New Relic APM
Deploy New Relic app performance management and know exactly
what is happening inside your Ruby, Python, PHP, Java, and .NET app
Try New Relic at no cost today and get our sweet Data Nerd shirt too!
http://p.sf.net/sfu/newrelic-dev2dev
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel