[edk2] StrSize() vs StrLen()

Subject: [edk2] StrSize() vs StrLen()

From: Sergey Isakov <isakov-sl@bk.ru>

To: edk2-devel@lists.sourceforge.net

Date: 2012-05-05 18:28:57

Hi sirs,

I am confusing with definition of the function StrSizeEx() in
IntelFrameworkModulePkg/Library/GenericBdsLib/BdsMisc.c
----------
/**
  Returns the length of a Null-terminated Unicode string. If the length is 
  bigger than MaxStringLen, return length 0 to indicate that this is an 
  invalidate string.

  This function returns the number of Unicode characters in the Null-terminated
  Unicode string specified by String. 

  If String is NULL, then ASSERT().
  If String is not aligned on a 16-bit boundary, then ASSERT().

  @param  String           A pointer to a Null-terminated Unicode string.
  @param  MaxStringLen     Max string len in this string.

  @retval 0                An invalid string.
  @retval Others           The length of String.

**/
UINTN
StrSizeEx (
  IN      CONST CHAR16              *String,
  IN      UINTN                     MaxStringLen
  )
{
  UINTN                             Length;

  ASSERT (String != NULL && MaxStringLen != 0);
  ASSERT (((UINTN) String & BIT0) == 0);

  for (Length = 0; *String != L'\0' && MaxStringLen != Length; String++, Length++);

  if (*String != L'\0' && MaxStringLen == Length) {
    return 0;
  }

  return (Length + 1) * sizeof (*String);
}

----------
I think this is just an inaccuracy in description as the function returns size in byte but not a number of Unicode characters.

Sergey