[if gte mso 9]>

Re: [edk2] [Code Review] ICC11 Build Falure on ShellPkg

Subject: Re: [edk2] [Code Review] ICC11 Build Falure on ShellPkg

From: "Gao, Liming" <liming.gao@intel.com>

To: "Carsey, Jaben" <jaben.carsey@intel.com>

Date: 2012-02-22 09:48:46

Jaben:

  The patch is good.

 

Reviewed-by: lgao4

 

Thanks

Liming

From: Carsey, Jaben
Sent: Wednesday, February 22, 2012 1:53 AM
To: Gao, Liming
Cc: edk2-devel@lists.sourceforge.net; Carsey, Jaben
Subject: [Code Review] ICC11 Build Falure on ShellPkg

 

Liming, 

 

Can you review this patch?

 

Thanks

-Jaben

 

ShellPkg: Fix ICC11 build failure.

 

Signed-off-by: jcarsey

 

From: Gao, Liming
Sent: Thursday, February 16, 2012 9:28 PM
To: Carsey, Jaben
Subject: ICC11 Build Falure on ShellPkg
Importance: High

 

Jaben:

  Could you help fix this build failure when ICC11 is used?

 

s:\bld\ShellPkg\Library\UefiShellInstall1CommandsLib\Bcfg.c(937): error #188: enumerated type mixed with another type

        ShellStatus = ShellOpenFileByName(

                    ^

 

s:\bld\ShellPkg\Library\UefiShellInstall1CommandsLib\Bcfg.c(943): error #188: enumerated type mixed with another type

          ShellStatus = ShellGetFileSize(FileHandle, &Intermediate);

                      ^

 

s:\bld\ShellPkg\Library\UefiShellInstall1CommandsLib\Bcfg.c(951): error #188: enumerated type mixed with another type

          ShellStatus = ShellReadFile(FileHandle, (UINTN *)&Intermediate, Data);

                      ^

 

Thanks

Liming