[if gte mso 9]>

Re: [edk2] DuetPkg: st32_64.S mistakes

Subject: Re: [edk2] DuetPkg: st32_64.S mistakes

From: "Sun, Rui" <rui.sun@intel.com>

To: "edk2-devel@lists.sourceforge.net" <edk2-devel@lists.sourceforge.net>

Date: 2012-01-13 14:33:08

Sergey,

 

You can verify the check in #12930.

 

Rui.

 

From: Sun, Rui [mailto:rui.sun@intel.com]
Sent: Wednesday, January 11, 2012 9:25 PM
To: edk2-devel@lists.sourceforge.net
Subject: Re: [edk2] DuetPkg: st32_64.S mistakes

 

Sergey

 

I am looking at this issue, and hope I can have a patch tomorrow.

 

Rui

 

From: Sergey Isakov [mailto:isakov-sl@bk.ru]
Sent: Wednesday, January 11, 2012 2:43 PM
To: edk2-devel@lists.sourceforge.net
Subject: Re: [edk2] DuetPkg: st32_64.S mistakes

 

Hi Rui,

 

I found a diff in old and new binary files at offset 0x370.

Old (from 0x360)

--------

C3 B9 00 00 E7 ED E4 64 24 02 E0 F8 C3 90 47 00

00 00 00 00 00 00 00 00 00 00 00 00 FF FF 00 00

--------

New

------

C3 B9 00 00 E7 ED E4 64 24 02 E0 F8 C3 90 47 00

00 00 00 00 00 00 00 00 00 00 00 00 00 00 FF FF

-------

Two bytes more.

It is in this place

-----

        ret

 

##############################################################################

# data

##############################################################################

 

        .p2align 1

 

        gdtr:    .long  GDT_END - GDT_BASE - 1  # GDT limit 

        .long 0                     # (GDT base gets set above)

##############################################################################

#   global descriptor table (GDT)

##############################################################################

 

        .p2align 1

 

GDT_BASE: 

# null descriptor

.equ                NULL_SEL, .-GDT_BASE    # Selector [0x0]

 

-----

Don't know why alignment works not as expected.

 

Sergey

 

On 11.01.2012, at 6:16, Sun, Rui wrote:

 

Sergey,

 

I just fixed the GCC build issue. I did not verify Duet64 built with GCC.

Could you debug it to see what is wrong?

 

From: Sergey Isakov [mailto:isakov-sl@bk.ru] 
Sent: Tuesday, January 10, 2012 4:32 PM
To: edk2-devel@lists.sourceforge.net
Subject: Re: [edk2] DuetPkg: st32_64.S mistakes

 

Hi Rui,

 

Your corrections are good. No more compiler's error and binary produced looks good.

But I still have a reboot with Duet64 at early stage of booting.

The same reboot I had with Duet32 until I corrected realMode->protectedMode switching. Now it was resolved.

But for Duet64 I don't know what it may be the issue.

 

Sergey.

 

On 10.01.2012, at 8:31, Sun, Rui wrote:



Hi, Sergey,

 

Please verify if the check in of #12921 fixes your problem.

 

Thanks,

Rui

 

From: Sergey Isakov [mailto:isakov-sl@bk.ru] 
Sent: Monday, January 09, 2012 6:07 AM
To: edk2-devel@lists.sourceforge.net
Subject: [edk2] DuetPkg: st32_64.S mistakes

 

Hi,

Please find a difference

---------------------

--- st32_64.S   2011-11-17 21:56:01.000000000 +0400

+++ st32_64-new.S    2012-01-09 01:51:48.000000000 +0400

@@ -27,6 +27,10 @@

 .equ                        BLOCK_SHIFT, 9

 

        .org 0x0

+

+.global _start

+_start:

+              

 Ia32Jump: 

   jmp   BootSectorEntryPoint  # JMP inst    - 3 bytes

   nop

@@ -142,7 +146,7 @@

         .byte 0xea

 jumpOffset: 

         .word 0x200

-jumpSegment: 

+JumpSegment: 

         .word 0x2000

 

 @@ -446,7 +458,7 @@

     #

     # Enable Protect Mode (set CR0.PE=1)

     #

-    movl  $cr0, %eax      # Read CR0.

+    movl  %cr0, %eax      # Read CR0.

     orl   $0x1,%eax       # Set PE=1

     movl  %eax, %cr0      # Write CR0.

     .byte 0x66

@@ -518,7 +530,7 @@

     #

     # Enable paging to activate long mode (set CR0.PG=1)

     #

-    movl  $cr0, %eax      # Read CR0.

+    movl  %cr0, %eax      # Read CR0.

     .byte 0xf

     .byte 0xba

     .byte 0xe8

----------------------

Sergey

------------------------------------------------------------------------------
Write once. Port to many.
Get the SDK and tools to simplify cross-platform app development. Create 
new or port existing apps to sell to consumers worldwide. Explore the 
Intel AppUpSM program developer opportunity. appdeveloper.intel.com/join
http://p.sf.net/sfu/intel-appdev_______________________________________________
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

 

------------------------------------------------------------------------------
Ridiculously easy VDI. With Citrix VDI-in-a-Box, you don't need a complex
infrastructure or vast IT resources to deliver seamless, secure access to
virtual desktops. With this all-in-one solution, easily deploy virtual 
desktops for less than the cost of PCs and save 60% on VDI infrastructure 
costs. Try it free! http://p.sf.net/sfu/Citrix-VDIinabox_______________________________________________
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel