Re: [edk2] [PATCH v2] MdeModulePkg: Remove variables that are set, but not used

Subject: Re: [edk2] [PATCH v2] MdeModulePkg: Remove variables that are set, but not used

From: "Sun, Rui" <rui.sun@intel.com>

To: "edk2-devel@lists.sourceforge.net" <edk2-devel@lists.sourceforge.net>

Date: 2011-10-28 17:31:43

Jordan,

You can check in the fix.

Please update the function description of Ip4OptionIsValid() after ICMP related code was removed.

-----Original Message-----
From: Sun, Rui [mailto:rui.sun@intel.com] 
Sent: Thursday, October 27, 2011 5:56 PM
To: edk2-devel@lists.sourceforge.net
Subject: Re: [edk2] [PATCH v2] MdeModulePkg: Remove variables that are set, but not used

Jordan,

For MdeModulePkg/Universal/Network/Ip4Dxe/Ip4Option.c, will changing the modifier "volatile" to "static" satisfy GCC 4.6? 

I will confirm with tye if those local variables can be simply removed.

-----Original Message-----
From: Jordan Justen [mailto:jljusten@gmail.com] 
Sent: Thursday, October 27, 2011 1:41 PM
To: edk2-devel@lists.sourceforge.net
Subject: [edk2] [PATCH v2] MdeModulePkg: Remove variables that are set, but not used

Rui, Liming, Feng and edk2 community,

Please review these attached change for MdeModulePkg to fix GCC 4.6 build issues.

This version adds Feng's suggestions for XhciDxe.

The commit message is contained in the patch file.

Thanks,

-Jordan

------------------------------------------------------------------------------
The demand for IT networking professionals continues to grow, and the
demand for specialized networking skills is growing even more rapidly.
Take a complimentary Learning@Cisco Self-Assessment and learn 
about Cisco certifications, training, and career opportunities. 
http://p.sf.net/sfu/cisco-dev2dev
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

------------------------------------------------------------------------------
The demand for IT networking professionals continues to grow, and the
demand for specialized networking skills is growing even more rapidly.
Take a complimentary Learning@Cisco Self-Assessment and learn 
about Cisco certifications, training, and career opportunities. 
http://p.sf.net/sfu/cisco-dev2dev
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel