Re: [edk2] [PATCH 4 of 5] OvmfPkg/SmbiosPlatformDxe: Publish Xen hvmloader SMBIOS inside OVMF

Subject: Re: [edk2] [PATCH 4 of 5] OvmfPkg/SmbiosPlatformDxe: Publish Xen hvmloader SMBIOS inside OVMF

From: Bei Guan <gbtju85@gmail.com>

To: Jordan Justen <jljusten@gmail.com>

Date: 2011-08-12 11:02:18

Hi Jordan,

This patch works well for Xen SMBIOS tables. Thank you very much.

Best Regards,
Bei

2011/8/12 Jordan Justen <jljusten@gmail.com>
Bei,

Can you verify the attached patch works for you for installing the Xen
SMBIOS tables?

Thanks,

-Jordan

On Tue, Aug 9, 2011 at 20:23, Bei Guan <gbtju85@gmail.com> wrote:
>
>
> 2011/8/10 Jordan Justen <jljusten@gmail.com>
>>
>> Bei,
>>
>> It seems like you could more easily parse through the Xen SMBIOS
>> structures 1-by-1, and publish all of them. Wouldn't this simplify
>> things?
>>
>> This seems preferable to this series of calls:
>> + InstallSmbiosType0 (EntryPointStructure);
>> + InstallSmbiosType1 (EntryPointStructure);
>> + InstallSmbiosType3 (EntryPointStructure);
>> ...
>
> Sorry, I don't quite understand you.
> In the patch, theGetSmbiosTableFromType() function takes the entry of Xen
> SMBIOS and the type of table as its input parameters, and parses the tables
> one by one. Then, by calling theEFI_SMBIOS_PROTOCOL=>Add (in
> methodsInstallSmbiosType[table type]), we can add the Xen tables into
> system table easily. Iwrittenthis patch by referring
> toDuetPkg/SmbiosGenDxe/. Is there any problem with it?
>
> Thanks,
> Bei
>
>>
>> -Jordan
>>
>> On Tue, Jul 26, 2011 at 18:49, Bei Guan <gbtju85@gmail.com> wrote:
>> > OvmfPkg/SmbiosPlatformDxe: Publish Xen hvmloader SMBIOS inside OVMF
>> > * Publish Xen SMBIOS inside UEFI. Support both QEMU and Xen.
>> > * Detect the Xen hvmloader SMBIOS.
>> > * Parses Xen BIOS structure one by one, add them to System Table.
>> > Signed-off-by: gavinguan
>> > (PS: "gavinguan" is my sourceforge login name.)
>> >
>> > 2011/7/24 Bei Guan <gbtju85@gmail.com>
>> >>
>> >> OvmfPkg/SmbiosPlatformDxe: Publish Xen hvmloader SMBIOS inside OVMF
>> >>
>> >> * Publish Xen SMBIOS inside UEFI. Support both QEMU and Xen.
>> >> * XenSmbiosSupport.c detect the Xen hvmloader SMBIOS.
>> >> * SmbiosPlatformDxe.c parses Xen BIOS structure one by one, and calls
>> >> EFI_SMBIOS_PROTOCOL=>Add to add them to UEFI System Table.
>> >>
>> >> Signed-off-by: Bei Guan
>> >>
>> >>
>> >>
>> >>
>> >> 2011/7/23 Bei Guan <gbtju85@gmail.com>
>> >>>
>> >>> SmbiosPlatformDxe publishes Xen hvmloader Smbios inside OVMF
>> >>
>> >
>> >
>
>