Re: [edk2] SF.net SVN: edk2:[11888] trunk/edk2/InOsEmuPkg/Unix

Subject: Re: [edk2] SF.net SVN: edk2:[11888] trunk/edk2/InOsEmuPkg/Unix

From: Jordan Justen <jljusten@gmail.com>

To: Andrew Fish <afish@apple.com>

Date: 2011-06-27 20:02:58

On Mon, Jun 27, 2011 at 11:49, Andrew Fish  wrote:
> On Jun 27, 2011, at 11:39 AM, Jordan Justen wrote:
>
>> On Mon, Jun 27, 2011 at 08:43, Andrew Fish  wrote:
>>>> + =A0//
>>>> + =A0// Check to see if the image symbols were loaded with gdb script,=
 or dlopen
>>>> + =A0//
>>>> + =A0Handle =3D RemoveHandle (ImageContext);
>>>> +
>>>> + =A0if (Handle =3D=3D NULL) {
>>>> +#ifndef __APPLE__
>>>> =A0 =A0 dlclose (Handle);
>>>> +#endif
>>>> + =A0 =A0return;
>>>> =A0 }
>>>>
>>>> -#endif
>>>> - =A0return;
>>>> + =A0GdbScriptRemoveImage (ImageContext);
>>>> }
>>>
>>>
>>> I think this should be (Handle !=3D NULL).
>>
>> Hmm, yes, there does seem to be an issues here.
>>
>> So should AddHandle be called by DlLoadImage rather than
>> GdbScriptAddImage? =A0(I think it was previously being called in the
>> __APPLE__ section...)
>>
>
> AddHandle() and RemoveHandle() exist to track dlopen() handle, they were =
not needed in the old Apple scheme. The return value from RemoveHandle() ne=
eds to be the dlopen handle, so it looks like AddHandle() needs to also get=
 passed dlopen handle and called when open succeeds.
>

Ok, since you are looking at it, can you make sure AddHandle and
RemoveHandle are used in the right places?

I looked at the old version of the file, and it previously was not
calling AddHandle when using dlopen, so that is where my confusion
came from...

>
> I think I've figured out how to fix Xcode symbol loading. This check in b=
roke it. I just need to do a little more testing to see if I can keep the G=
dbRun script common.
>

Does Xcode use the scripts?

> Why don't we change names after these issues get fixed? So we are doing t=
he change on a known working version. I should be able to get the Xcode fix=
es checked in this afternoon.
>

Yes, sounds good.

-Jordan

---------------------------------------------------------------------------=
---
All of the data generated in your IT infrastructure is seriously valuable.
Why? It contains a definitive record of application performance, security =

threats, fraudulent activity, and more. Splunk takes this data and makes =

sense of it. IT sense. And common sense.
http://p.sf.net/sfu/splunk-d2d-c2
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel