Re: [edk2] ShellPkg: ls Crashes if RTC is bad

Subject: Re: [edk2] ShellPkg: ls Crashes if RTC is bad

From: "Cohen, Eugene" <eugene@hp.com>

To: "edk2-devel@lists.sourceforge.net" <edk2-devel@lists.sourceforge.net>

Date: 2011-05-26 04:12:00

Hi Jaben.

Maybe a debug statement (D_WARN) would suffice?

Eugene

-----Original Message-----
From: Carsey, Jaben [mailto:jaben.carsey@intel.com] 
Sent: Wednesday, May 25, 2011 1:57 PM
To: edk2-devel@lists.sourceforge.net
Subject: Re: [edk2] ShellPkg: ls Crashes if RTC is bad

I agree with the correction.  Do you think that a message should be output to warn that something went wrong?

-Jaben

-----Original Message-----
From: Cohen, Eugene [mailto:eugene@hp.com] 
Sent: Wednesday, May 25, 2011 12:32 PM
To: edk2-devel@lists.sourceforge.net
Subject: Re: [edk2] ShellPkg: ls Crashes if RTC is bad

Here's a patch for the ShellPkg GetTime ASSERT in Ls.c.

-----Original Message-----
From: Cohen, Eugene
Sent: Tuesday, May 24, 2011 6:17 AM
To: edk2-devel@lists.sourceforge.net
Subject: [edk2] ShellPkg: ls Crashes if RTC is bad

In ShellPkg\Library\UefiShellLevel2CommandsLib\Ls.c, ShellCommandRunLs calls GetTime to figure out the time zone but ASSERTs if the RTC is non-functional:

        Status = gRT->GetTime(&TheTime, NULL);
        ASSERT_EFI_ERROR(Status);

I think the shell should tolerate the error condition gracefully and not assert.

Eugene


------------------------------------------------------------------------------
vRanger cuts backup time in half-while increasing security.
With the market-leading solution for virtual backup and recovery, you get blazing-fast, flexible, and affordable data protection.
Download your free trial now. 
http://p.sf.net/sfu/quest-d2dcopy1
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

------------------------------------------------------------------------------
vRanger cuts backup time in half-while increasing security.
With the market-leading solution for virtual backup and recovery, 
you get blazing-fast, flexible, and affordable data protection.
Download your free trial now. 
http://p.sf.net/sfu/quest-d2dcopy1
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel

------------------------------------------------------------------------------
vRanger cuts backup time in half-while increasing security.
With the market-leading solution for virtual backup and recovery, 
you get blazing-fast, flexible, and affordable data protection.
Download your free trial now. 
http://p.sf.net/sfu/quest-d2dcopy1
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/edk2-devel