[edk2] Why are screen modes hardcoded in GraphicsConsole.h with a comment that some one should change the include file in the MdeModulePkg?

Subject: [edk2] Why are screen modes hardcoded in GraphicsConsole.h with a comment that some one should change the include file in the MdeModulePkg?

From: Andrew Fish <afish@apple.com>

To: edk2-devel@lists.sourceforge.net

Date: 2011-02-10 17:11:18

  • 2011-02-10 17:11:18  Andrew Fish   [edk2] Why are screen modes hardcoded in GraphicsConsole.h with a comment that some one should change the include file in the MdeModulePkg?


edk2/MdeModulePkg/Universal/Console/GraphicsConsoleDxe/GraphicsConsole.h

//
// User can define valid graphic resolution here
// e.g. 640x480, 800x600, 1024x768...
//
#define CURRENT_HORIZONTAL_RESOLUTION  800
#define CURRENT_VERTICAL_RESOLUTION    600


Seems like these should be PCD values?

Andrew Fish