Subject: RE: [Edk2 Dev] Potential DXE IPL compatibility issue.
From: "Huang, Qing" <firstname.lastname@example.org>
Date: 2008-07-19 18:15:44
Yes, your suggestion can further help to save the extra GUID copy and reduce one parameter of DxeIplFindDxeCore().
I have checked in to refine the code as you have suggested. Really appreciate your contributions to improve our source level code quality!
Thanks & Best Regards,
From: Andrew Fish
Sent: Saturday, July 19, 2008 7:30 AM
Subject: Re: [Edk2 Dev] Potential DXE IPL compatibility issue.
Your fix looks good, but I don't think we need DxeCoreFileName. We are just copying the GUID data from the buffer from GetFileInfo into a buffer on our stack so we can take the address of it and pass it into BuildModuleHob (). Why not just pass in the pointer to the GUID from FvFileInfo like this:
EFI_SIZE_TO_PAGES ((UINT32) DxeCoreSize) * EFI_PAGE_SIZE,
We could then remove DxeCoreFileName and simplify the code.